-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
summary-always
updates benchmarks twice, fails with gh-pages
#158
Comments
comment-always
does not work without external-data-json-path
summary-always
updates benchmarks twice, fails with gh-pages
Another issue is with the rendering, see: https://github.com/timbray/quamina/actions/runs/4393672754 (example) where the numbers are markdown formatted but not properly rendered. |
@embano1 You should probably open a separate issue for that |
Yeah, was too lazy as yours was top of list when I just checked...sorry for polluting your issue. #159 |
has anyone started to work on this? |
This is currently broken - see this [issue](benchmark-action/github-action-benchmark#158).
I believe this was fixed by #214 |
Verified! |
If
summary-always
is true, we call firstwriteBenchmark
, thenwriteSummary
.github-action-benchmark/src/index.ts
Lines 13 to 17 in 060e110
But both of these call
writeBenchmarkToGitHubPages
by default, so we will create the commit twice. In fact we don't even get that far because the second invocation'sgit fetch
will fail to update thegh-pages
branch because of the new commit available only locally whenauto-push
is false.Example run: https://github.com/Kha/nale/actions/runs/4375198974/jobs/7656891394
The text was updated successfully, but these errors were encountered: