Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable non-ABI3 libs linking test for Windows #2461

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

nicholasjng
Copy link
Contributor

Also explicitly include ABI3 in the name of the other Windows-only testcase, since that is the whole point of the test, and no ABI3-only libs exist on non-Windows platforms.


Follow-up of #1820.

Also explicitly include ABI3 in the name of the other Windows-only testcase,
since that is the whole point of the test, and no ABI3-only libs exist on
non-Windows platforms.
@nicholasjng
Copy link
Contributor Author

also:

# someone with more C + Windows experience will have to figure it out.

couldn't be me, but I am glad it all worked out in the end. :^)

@aignas aignas added this pull request to the merge queue Dec 3, 2024
Merged via the queue into bazelbuild:main with commit 096a04f Dec 3, 2024
4 checks passed
@nicholasjng nicholasjng deleted the rework-cc-test branch December 3, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants