Skip to content

Commit

Permalink
test: Enable non-ABI3 libs linking test for Windows (#2461)
Browse files Browse the repository at this point in the history
Also explicitly include ABI3 in the name of the other Windows-only
testcase, since that is the whole point of the test, and no ABI3-only
libs exist on non-Windows platforms.

-----------

Follow-up of #1820.
  • Loading branch information
nicholasjng authored Dec 3, 2024
1 parent bc8658a commit 096a04f
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions tests/cc/current_py_cc_libs/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,6 @@ current_py_cc_libs_test_suite(name = "current_py_cc_libs_tests")
cc_test(
name = "python_libs_linking_test",
srcs = ["python_libs_linking_test.cc"],
# Windows fails with linking errors, but its not clear why; someone
# with more C + Windows experience will have to figure it out.
# - rickeylev@
target_compatible_with = select({
"@platforms//os:linux": [],
"@platforms//os:osx": [],
"//conditions:default": ["@platforms//:incompatible"],
}),
deps = [
"@rules_python//python/cc:current_py_cc_headers",
"@rules_python//python/cc:current_py_cc_libs",
Expand All @@ -41,10 +33,9 @@ cc_test(
# for libs/python3.lib.
# buildifier: disable=native-cc
cc_test(
name = "python_libs_linking_windows_test",
name = "python_abi3_libs_linking_windows_test",
srcs = ["python_libs_linking_test.cc"],
defines = ["Py_LIMITED_API=0x030A0000"],
env = {"HELLO": "world"},
target_compatible_with = ["@platforms//os:windows"],
deps = [
"@rules_python//python/cc:current_py_cc_headers",
Expand Down

0 comments on commit 096a04f

Please sign in to comment.