Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PatchActionConvert reuse old cell processes #94

Open
allison-li-1016 opened this issue Nov 13, 2024 · 2 comments
Open

Make PatchActionConvert reuse old cell processes #94

allison-li-1016 opened this issue Nov 13, 2024 · 2 comments
Labels
category: agent Related to the agent subpackages package: patch Related to the patch implementation size: medium Estimated size of issue or PR is medium type: feature Improvement or additions to the code base

Comments

@allison-li-1016
Copy link
Contributor

allison-li-1016 commented Nov 13, 2024

The PatchActionConvert class represents mutation of one cell type to another (e.g. a healthy tissue cell mutating into a cancer cell). Currently it is implemented by removing the current cell, making a new cell of the different cell type, and inserting the new cell into the simulation at the same location of the old cell.

Instantiating a new process for the new cell initializes all internal amounts at the initial concentration parameter values, which does not represent the current state of the mutated cell. Instead of creating a new process for the new cell, we want to re-use the same processes from the old cell to accurately represent the internal amounts of metabolites and signaling molecules.

@cainja
Copy link
Member

cainja commented Nov 14, 2024

This is a tricky one, maybe @jessicasyu will have some thoughts because I've never really used this action -

In order to update the module from the old cell, the modules would need to be the same.
(1) would there ever be a use case that the cell conversion that's happening would be from a population using one module to another using a different module (i.e. one uses simple and the other uses complex)
(2) have we used this in published simulations? I have only inserted cell populations and have not tried to convert them. it seems strange to only grab the cell at the center of the simulation if there is one...

@jessicasyu
Copy link
Member

@cainja The goal of this action is to capture a healthy tissue cell "mutating" into a cancerous one sometime during the simulation.

  1. I can't think of a use case, but the setup file does allow for different modules versions for each population, so you would technically need to support it
  2. We have not used it in published simulations

@jessicasyu jessicasyu added type: feature Improvement or additions to the code base package: patch Related to the patch implementation category: agent Related to the agent subpackages size: medium Estimated size of issue or PR is medium labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: agent Related to the agent subpackages package: patch Related to the patch implementation size: medium Estimated size of issue or PR is medium type: feature Improvement or additions to the code base
Projects
None yet
Development

No branches or pull requests

3 participants