Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unify handling of install prefix #863

Merged
merged 1 commit into from
Mar 21, 2024
Merged

fix: unify handling of install prefix #863

merged 1 commit into from
Mar 21, 2024

Conversation

mistydemeo
Copy link
Contributor

I previously tried to inline the env subdir reference, but this didn't work on PowerShell. Instead, using the same logic as CARGO_HOME should make sure it gets referenced properly and cleaned up so it's JSON-valid.

@mistydemeo mistydemeo requested a review from Gankra March 20, 2024 18:59
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to at least be rebased on #862 and to address the FIXME in it

cargo-dist/src/tasks.rs Outdated Show resolved Hide resolved
I previously tried to inline the env subdir reference, but this didn't work
on PowerShell. Instead, using the same logic as CARGO_HOME should make sure
it gets referenced properly *and* cleaned up so it's JSON-valid.
@mistydemeo mistydemeo merged commit a10d300 into main Mar 21, 2024
15 checks passed
@mistydemeo mistydemeo deleted the fix_env_subdir branch March 21, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants