Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add ruin_me powershell tests #862

Merged
merged 2 commits into from
Mar 21, 2024
Merged

chore: add ruin_me powershell tests #862

merged 2 commits into from
Mar 21, 2024

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Mar 20, 2024

No description provided.

Comment on lines 580 to 608
// check the install receipts
// FIXME: temporarily disabled for the feature being broken
// self.check_install_receipt(ctx, &bin_dir, &receipt_file, ".exe");
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

todo for @mistydemeo: fix install receipts and uncomment this line

Copy link
Contributor

@mistydemeo mistydemeo Mar 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase with this uncommented works: #866

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can reenable this now that #863 is merged.

cargo-dist/tests/gallery/dist.rs Outdated Show resolved Hide resolved
&tempdir,
"savepath.ps1",
r#"
$Item = Get-Item -Path "HKCU:\Environment"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh man

// checking path...
// Make a test.ps1 script that runs `where.exe {bin_name}`
//
// (note that "where" and "where.exe" are completely different things...)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh NO

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gankra Gankra merged commit 158f177 into main Mar 21, 2024
15 checks passed
@Gankra Gankra deleted the ruin_ps1 branch March 21, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants