fix: Avoid 'dist migrate' deleting dist-workspace.toml. #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A condition like the following was intended to be inverted:
A == B && C == D
The inverse of this would be:
A != B || C != D
However, instead, what we had was this partially-inverted logic:
A != B && C != D
In practice, because of the specific things we were checking, this meant
instead of *never* deleting dist-workspace.toml, we were *always*
deleting it.
5 tasks
|
Fortunately, a duplicate check in |
duckinator
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A condition like the following was intended to be switched from
==to!=:The correct way to do this would be:
However, instead, what we had was this inverted logic:
In practice, because of the specific things we were checking, this meant instead of never deleting dist-workspace.toml, we were always deleting it.