[WIP] Implement config v0 -> v1 migration. #1653
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duckinator
force-pushed
the
dist-migrate-v1
branch
3 times, most recently
from
ebcaa00 to
ce26547
Compare
A condition like the following was intended to be inverted:
A == B && C == D
The inverse of this would be:
A != B || C != D
However, instead, what we had was this partially-inverted logic:
A != B && C != D
In practice, because of the specific things we were checking, this meant
instead of *never* deleting dist-workspace.toml, we were *always*
deleting it.
duckinator
force-pushed
the
dist-migrate-v1
branch
from
ce26547 to
9a7d939
Compare
|
This is currently based off #1661. When that gets merged, I'll rebase off |
duckinator
force-pushed
the
dist-migrate-v1
branch
from
9a7d939 to
8670bcb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required functionality for this PR:
dist migratemove v0 to v1do_migrate_from_v0()actually copy workspace members to the new configuration.dist inituse v1dist initload v1dist plan(and other commands) gives an actionable error for v0 configsCurrent state: