-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dist plan
handle mismatched project versions
#1554
Comments
I'm not entirely sure that we want to keep the exact "There are too many ..."/"help: ..." text we have now, but I'm also not sure what to replace it with. I think the information it's conveying is useful, but may be a bit confusing when combined with information on what There is also the open question of how to handle the JSON output. |
I am running into a similar issue, where dist plan is being run as a PR check (I believe this is how cargo dist sets itself up?) and because a PR does not have a specific tag, I couldn't even apply one if I wanted to. So in short. Doing this check when running as part of a PR check, seems like a bug to me. |
I just went through all the notes I have and what @alilleybrinker has mentioned, and I boiled it all down to 3 chunks and a stopgap measure for usability:
The first one being the most important, since it is actively causing problems for multiple users. With just the first one resolved, mismatched tags/versions + the default |
If there's packages with two different versions (let's say foo + bar 1.0.0 and baz 2.0.0), currently
dist plan
fails like this:It would be useful to have it figure out what potential tags there are, and then generate the usual
dist plan
output for each one.Possibly something closer to this:
The text was updated successfully, but these errors were encountered: