Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pr-run-mode="upload" handle multiple tags #1596

Open
duckinator opened this issue Dec 3, 2024 · 0 comments
Open

Make pr-run-mode="upload" handle multiple tags #1596

duckinator opened this issue Dec 3, 2024 · 0 comments

Comments

@duckinator
Copy link
Contributor

duckinator commented Dec 3, 2024

With #1579, dist plan can handle workspaces having projects with different versions.

However, that change means workflows generated with pr-run-mode="upload" will fail on the build job, so #1587 made it fail in the plan job for better UX.

The proper solution would be to have workflows generated with pr-run-mode="upload" run dist build for every discovered tag, and undo the changes made in #1587.

This may involve adding a subcommand which lists all known tags. #1595 includes code that does this.

(Split this off of #1554.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant