Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating real-world interactions of dist plan and dist build #1565

Closed
duckinator opened this issue Nov 18, 2024 · 0 comments
Closed

Investigating real-world interactions of dist plan and dist build #1565

duckinator opened this issue Nov 18, 2024 · 0 comments

Comments

@duckinator
Copy link
Contributor

duckinator commented Nov 18, 2024

!!! This is a WIP. I'm still researching all the information. It will be changing a lot. !!!

dist plan vs dist build

This issue serves as a deep dive into how dist plan and dist build behave in the real world, in an attempt to find a proper resolution to #1554 and #1560.

All of this is accurate on main, as of November 18 2024.

Axioms

Things that we are defining as true:

  1. dist plan succeeding means an equivalent dist build should succeed.
  2. --

Observations

Things we have verified are true:

  1. dist plan currently fails when workspaces have multiple distinct versions and --tag isn't specified.
  2. in PR workflows, dist plan is guaranteed to have less information than dist build in a detrimental way: PRs don't have a tag, so if there's multiple versions we can't specify --tag.
  3. if we change how dist plan so it tries every option, it risks dist plan succeeding when dist build would fail.
  4. --

Assumptions

Things we believe are true, but have not verified:

  1. dist plan fails with mismatched versions but no --tag because it warns us about failing dist build runs.
  2. --

Open Questions

Things we need to answer:

  1. what does "equivalent" mean in the context of a dist plan run vs a dist build run?
  2. --

Actionable Tasks

Things we need to do:

  1. --
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant