You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
!!! This is a WIP. I'm still researching all the information. It will be changing a lot. !!!
dist plan vs dist build
This issue serves as a deep dive into how dist plan and dist build behave in the real world, in an attempt to find a proper resolution to #1554 and #1560.
All of this is accurate on main, as of November 18 2024.
Axioms
Things that we are defining as true:
dist plan succeeding means an equivalent dist build should succeed.
--
Observations
Things we have verified are true:
dist plan currently fails when workspaces have multiple distinct versions and --tag isn't specified.
in PR workflows, dist plan is guaranteed to have less information than dist build in a detrimental way: PRs don't have a tag, so if there's multiple versions we can't specify --tag.
if we change how dist plan so it tries every option, it risks dist plan succeeding when dist build would fail.
--
Assumptions
Things we believe are true, but have not verified:
dist plan fails with mismatched versions but no --tag because it warns us about failing dist build runs.
--
Open Questions
Things we need to answer:
what does "equivalent" mean in the context of a dist plan run vs a dist build run?
--
Actionable Tasks
Things we need to do:
--
The text was updated successfully, but these errors were encountered:
!!! This is a WIP. I'm still researching all the information. It will be changing a lot. !!!
dist plan
vsdist build
This issue serves as a deep dive into how
dist plan
anddist build
behave in the real world, in an attempt to find a proper resolution to #1554 and #1560.All of this is accurate on main, as of November 18 2024.
Axioms
Things that we are defining as true:
dist plan
succeeding means an equivalentdist build
should succeed.Observations
Things we have verified are true:
dist plan
currently fails when workspaces have multiple distinct versions and--tag
isn't specified.dist plan
is guaranteed to have less information thandist build
in a detrimental way: PRs don't have a tag, so if there's multiple versions we can't specify--tag
.dist plan
so it tries every option, it risksdist plan
succeeding whendist build
would fail.Assumptions
Things we believe are true, but have not verified:
dist plan
fails with mismatched versions but no--tag
because it warns us about failingdist build
runs.Open Questions
Things we need to answer:
dist plan
run vs adist build
run?Actionable Tasks
Things we need to do:
The text was updated successfully, but these errors were encountered: