Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(gumby): add Java/Maven version fields #679

Merged
merged 1 commit into from
Jan 29, 2024
Merged

telemetry(gumby): add Java/Maven version fields #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions telemetry/definitions/commonDefinitions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -979,6 +979,16 @@
"type": "string",
"description": "A general string field to represent the result of the project"
},
{
"name": "codeTransformLocalJavaVersion",
"type": "string",
"description": "A string field to represent the Java version on the user's machine"
Copy link
Contributor

@justinmk3 justinmk3 Jan 31, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to repeat the data type in the description.

"description": "A string field to represent the Java version on the user's machine"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix in my next PR

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#682

},
{
"name": "codeTransformLocalMavenVersion",
"type": "string",
"description": "A string field to represent the Maven version on the user's machine"
},
{
"name": "codeTransformRuntimeError",
"type": "string",
Expand Down Expand Up @@ -3509,6 +3519,14 @@
{
"type": "codeTransformResultStatusMessage",
"required": false
},
{
"type": "codeTransformLocalJavaVersion",
"required": false
},
{
"type": "codeTransformLocalMavenVersion",
"required": false
}
]
},
Expand Down
Loading