telemetry(gumby): add Java/Maven version fields #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tincheng
approved these changes
Jan 27, 2024
nkomonen-amazon
approved these changes
Jan 29, 2024
justinmk3
reviewed
Jan 31, 2024
| { | ||
| "name": "codeTransformLocalJavaVersion", | ||
| "type": "string", | ||
| "description": "A string field to represent the Java version on the user's machine" |
There was a problem hiding this comment.
Don't need to repeat the data type in the description.
"description": "
A string field to representthe Java version on the user's machine"
There was a problem hiding this comment.
Will fix in my next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We need to track the Java version and Maven version on the user's machine for insight into why a shell command we run is failing.
Solution
Add those version fields to an existing metric.
License
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.