Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle valid JSON messages which are not GreengrassLogMessages #214

Merged
merged 2 commits into from
Oct 27, 2023

fix(uat): update broken UAT test

73b73c7
Select commit
Loading
Failed to load commit list.
Merged

fix: handle valid JSON messages which are not GreengrassLogMessages #214

fix(uat): update broken UAT test
73b73c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 26, 2023 in 1s

85.36% (-0.99%) compared to e18e5cf

View this Pull Request on Codecov

85.36% (-0.99%) compared to e18e5cf

Details

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e18e5cf) 86.35% compared to head (73b73c7) 85.36%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #214      +/-   ##
==========================================
- Coverage   86.35%   85.36%   -0.99%     
==========================================
  Files          13       13              
  Lines        1033     1052      +19     
  Branches      106      109       +3     
==========================================
+ Hits          892      898       +6     
- Misses         87       96       +9     
- Partials       54       58       +4     
Files Coverage Δ
.../aws/greengrass/logmanager/model/LogFileGroup.java 75.82% <0.00%> (ø)
...m/aws/greengrass/logmanager/LogManagerService.java 87.10% <33.33%> (+0.12%) ⬆️
...a/com/aws/greengrass/logmanager/model/LogFile.java 75.34% <0.00%> (-3.23%) ⬇️
...ass/logmanager/CloudWatchAttemptLogsProcessor.java 86.48% <33.33%> (-3.69%) ⬇️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.