Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle valid JSON messages which are not GreengrassLogMessages #214

Merged
merged 2 commits into from
Oct 27, 2023

fix(uat): update broken UAT test

73b73c7
Select commit
Loading
Failed to load commit list.
Merged

fix: handle valid JSON messages which are not GreengrassLogMessages #214

fix(uat): update broken UAT test
73b73c7
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Oct 26, 2023 in 0s

27.27% of diff hit (target 86.35%)

View this Pull Request on Codecov

27.27% of diff hit (target 86.35%)

Annotations

Check warning on line 195 in src/main/java/com/aws/greengrass/logmanager/CloudWatchAttemptLogsProcessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/aws/greengrass/logmanager/CloudWatchAttemptLogsProcessor.java#L191-L195 

Added lines #L191 - L195 were not covered by tests

Check warning on line 205 in src/main/java/com/aws/greengrass/logmanager/CloudWatchAttemptLogsProcessor.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/aws/greengrass/logmanager/CloudWatchAttemptLogsProcessor.java#L202-L205 

Added lines #L202 - L205 were not covered by tests

Check warning on line 706 in src/main/java/com/aws/greengrass/logmanager/LogManagerService.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/aws/greengrass/logmanager/LogManagerService.java#L706 

Added line #L706 was not covered by tests

Check warning on line 95 in src/main/java/com/aws/greengrass/logmanager/model/LogFile.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/aws/greengrass/logmanager/model/LogFile.java#L93-L95 

Added lines #L93 - L95 were not covered by tests

Check warning on line 138 in src/main/java/com/aws/greengrass/logmanager/model/LogFileGroup.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/com/aws/greengrass/logmanager/model/LogFileGroup.java#L138 

Added line #L138 was not covered by tests
View more details on Codecov