-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add autoware_core_component_interface_specs package #124
base: main
Are you sure you want to change the base?
feat: add autoware_core_component_interface_specs package #124
Conversation
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
3f92a0e
to
8aba5d9
Compare
6129660
to
fb905d6
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 73.25% 64.95% -8.30%
==========================================
Files 10 17 +7
Lines 172 234 +62
Branches 68 104 +36
==========================================
+ Hits 126 152 +26
Misses 19 19
- Partials 27 63 +36
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
6f5a07c
to
775a0f0
Compare
Signed-off-by: Ryohsuke Mitsudome <[email protected]>
static constexpr char name[] = ""; | ||
static constexpr size_t depth = 1; | ||
static constexpr auto reliability = RMW_QOS_POLICY_RELIABILITY_RELIABLE; | ||
static constexpr auto durability = RMW_QOS_POLICY_DURABILITY_VOLATILE; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These don't seem necessary. If your goal is to share get_qos function, how about making it a free function or using the CRTP?
Description
This creates a new autoware_core_component_interface_specs package in to Autoware Core.
This package is based on autoware_component_interface_specs. The main differences are the followings:
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.