Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes SWC compilation pipeline in prep for RSPack #14903

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

damassi
Copy link
Member

@damassi damassi commented Nov 24, 2024

The type of this PR is: Chore

⚠️ Stacked PR on #14902, so that needs to be merged first

Description

As we'll soon be moving to https://rspack.dev/, this removes our SWC configuration.

cc @artsy/diamond-devs

@damassi damassi requested a review from a team November 24, 2024 06:05
@damassi damassi self-assigned this Nov 24, 2024
Copy link

relativeci bot commented Nov 24, 2024

#1032 Bundle Size — 9.56MiB (+0.13%).

41fae0e(current) vs ffe4f84 main#484(baseline)

Important

Bundle introduced 1 and removed 4 duplicate packages – View changed duplicate packages

Warning

Bundle introduced 3 new packages: web-vitals, @sentry-internal/browser-utils, stylis – View changed packages

Bundle metrics  Change 8 changes Regression 1 regression Improvement 3 improvements
                 Current
#1032
     Baseline
#484
Improvement  Initial JS 3.69MiB(-6.57%) 3.95MiB
No change  Initial CSS 0B 0B
Change  Cache Invalidation 87.82% 2.04%
Change  Chunks 142(-0.7%) 143
No change  Assets 146 146
Change  Modules 5697(+1.06%) 5637
Regression  Duplicate Modules 501(+10.11%) 455
Change  Duplicate Code 6.12%(+4.08%) 5.88%
Improvement  Packages 282(-3.09%) 291
Improvement  Duplicate Packages 39(-7.14%) 42
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#1032
     Baseline
#484
Regression  JS 9.35MiB (+0.39%) 9.31MiB
Improvement  Other 213.41KiB (-10.27%) 237.84KiB

Bundle analysis reportBranch remove-swcProject dashboard


Generated by RelativeCIDocumentationReport issue

@damassi
Copy link
Member Author

damassi commented Nov 27, 2024

Bye bye

@damassi damassi merged commit feb8294 into streaming-3 Nov 27, 2024
11 checks passed
@damassi damassi deleted the remove-swc branch November 27, 2024 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant