chore: remove swc in prep for RSPack

artsy · Nov 24, 2024 · 03f3478 · 03f3478
1 parent f91d173
commit 03f3478
Show file tree

Hide file tree

Showing 14 changed files with 5 additions and 381 deletions.
diff --git a/.gitignore b/.gitignore
@@ -6,7 +6,6 @@
 .env
 .env.*
 !.env.development
-.swc/
 .yalc
 *.csv
 *.dat

diff --git a/.swcrc.js b/.swcrc.js
diff --git a/HACKS.md b/HACKS.md
diff --git a/__mocks__/@loadable/component.tsx b/__mocks__/@loadable/component.tsx
@@ -1,16 +1,7 @@
 import React from "react"
 
 async function loadable(load, { resolveComponent }) {
-  let Component
-
-  // If running jest using babel, lean on babel-plugin-loadable
-  // TODO: Remove this when we fully switch to SWC
-  if (load.requireSync) {
-    Component = resolveComponent(load.requireSync())
-    // Using SWC compiler, no transform; load like normal
-  } else {
-    Component = resolveComponent(await load())
-  }
+  let Component = resolveComponent(load.requireSync())
 
   const Loadable = props => {
     return <Component {...props} />

diff --git a/coffeelint.json b/coffeelint.json
diff --git a/jest.config.js b/jest.config.js
@@ -1,10 +1,5 @@
-const swcConfig = require("./.swcrc.js")
 const { webpackEnv } = require("./webpack/webpackEnv")
 
-if (webpackEnv.experimentalSWCCompiler) {
-  console.log("[jest.config.js] Experimental SWC Compiler is enabled.\n")
-}
-
 module.exports = {
   cacheDirectory: ".cache/jest",
   moduleDirectories: ["node_modules", "<rootDir>/src"],
@@ -25,9 +20,7 @@ module.exports = {
   },
   transform: {
     "\\.(gql|graphql)$": "@graphql-tools/jest-transform",
-    "(ts|tsx|js|jsx)$": webpackEnv.experimentalSWCCompiler
-      ? ["@swc/jest", swcConfig]
-      : "babel-jest",
+    "(ts|tsx|js|jsx)$": "babel-jest",
   },
   watchPlugins: [
     "jest-watch-typeahead/filename",

diff --git a/jest.legacy.config.js b/jest.legacy.config.js
@@ -1,4 +1,3 @@
-const swcConfig = require("./.swcrc.js")
 const { webpackEnv } = require("./webpack/webpackEnv")
 
 module.exports = {

diff --git a/package.json b/package.json
@@ -228,10 +228,6 @@
     "@storybook/builder-webpack5": "6.5.13",
     "@storybook/manager-webpack5": "6.5.13",
     "@storybook/react": "6.5.13",
-    "@swc/core": "^1.3.95",
-    "@swc/jest": "^0.2.29",
-    "@swc/plugin-relay": "^1.5.94",
-    "@swc/plugin-styled-components": "^1.5.94",
     "@testing-library/jest-dom": "^6.6.3",
     "@testing-library/react": "^16.0.1",
     "@testing-library/react-hooks": "^8.0.1",
@@ -337,7 +333,6 @@
     "size-plugin": "^3.0.0",
     "storybook-states": "1.2.0",
     "style-loader": "0.23.1",
-    "swc-loader": "^0.2.3",
     "terser-webpack-plugin": "5.1.3",
     "time-fix-plugin": "^2.0.7",
     "typescript": "^5.6.3",

diff --git a/scripts/clean.sh b/scripts/clean.sh
@@ -3,7 +3,6 @@
 set -ex
 
 rm -rf .cache
-rm -rf .swc
 rm -f manifest.json
 rm -rf public
 mkdir public

diff --git a/...rAuthentication/__tests__/SettingsEditSettingsTwoFactorBackupCodesActions.jest.enzyme.tsx b/...rAuthentication/__tests__/SettingsEditSettingsTwoFactorBackupCodesActions.jest.enzyme.tsx
@@ -55,8 +55,7 @@ describe("Two factor authentication enrollment", () => {
       expect(downloadButton.text()).toBe("Download")
     })
 
-    // FIXME: SWC_COMPILER_MIGRATION
-    it.skip("enables user to download the recovery codes", () => {
+    it("enables user to download the recovery codes", () => {
       global.URL.createObjectURL = jest.fn()
       global.URL.revokeObjectURL = jest.fn()
 

diff --git a/webpack/envs/clientDevelopmentConfig.js b/webpack/envs/clientDevelopmentConfig.js
@@ -12,7 +12,7 @@ import webpack from "webpack"
 import { basePath, webpackEnv } from "../webpackEnv"
 import { splitChunks } from "../bundleSplitting"
 import { sharedPlugins } from "../sharedPlugins"
-import { babelLoader, ejsLoader, mjsLoader, swcLoader } from "../sharedLoaders"
+import { babelLoader, ejsLoader, mjsLoader } from "../sharedLoaders"
 
 import {
   cache,
@@ -26,10 +26,6 @@ import {
 
 console.log("\n[Force] Building client-side development code...\n")
 
-if (webpackEnv.experimentalSWCCompiler) {
-  console.log("[Force] Experimental SWC Compiler is enabled.\n")
-}
-
 export const clientDevelopmentConfig = () => {
   return {
     cache,
@@ -44,11 +40,7 @@ export const clientDevelopmentConfig = () => {
     externals,
     mode,
     module: {
-      rules: [
-        webpackEnv.experimentalSWCCompiler ? swcLoader : babelLoader,
-        ejsLoader,
-        mjsLoader,
-      ],
+      rules: [babelLoader, ejsLoader, mjsLoader],
     },
     optimization: {
       runtimeChunk: "single", // Extract webpack runtime code into it's own file

diff --git a/webpack/sharedLoaders.js b/webpack/sharedLoaders.js
@@ -2,18 +2,6 @@
 
 import path from "path"
 import { basePath, webpackEnv } from "./webpackEnv"
-import swcConfig from "../.swcrc.js"
-
-export const swcLoader = {
-  include: path.resolve(basePath, "src"),
-  test: /(\.(js|ts)x?$)/,
-  use: [
-    {
-      loader: "swc-loader",
-      options: swcConfig,
-    },
-  ],
-}
 
 export const babelLoader = {
   exclude: /(node_modules)/,

diff --git a/webpack/webpackEnv.js b/webpack/webpackEnv.js
@@ -8,8 +8,6 @@ loadEnvs(".env.shared", ".env")
 const webpackEnv = {
   isDevelopment: process.env.NODE_ENV === "development",
   isProduction: process.env.NODE_ENV === "production",
-  experimentalSWCCompiler:
-    process.env.EXPERIMENTAL_SWC_COMPILER_ENABLED === "true",
 }
 
 const basePath = process.cwd()
@@ -24,7 +22,6 @@ if (process.env.CI || process.env.WEBPACK_LOG_CONFIG) {
   console.log("\n[Webpack Environment]")
   console.log("  basePath".padEnd(40), chalk.yellow(basePath))
   console.log("  CI".padEnd(40), chalk.yellow(process.env.CI))
-  console.log("  EXPERIMENTAL_SWC_COMPILER_ENABLED".padEnd(40), chalk.yellow(webpackEnv.experimentalSWCCompiler))
   console.log("  NODE_ENV".padEnd(40), chalk.yellow(process.env.NODE_ENV))
   console.log("  WEBPACK_BUNDLE_REPORT".padEnd(40), chalk.yellow(process.env.WEBPACK_BUNDLE_REPORT))
   console.log("  WEBPACK_DEVTOOL".padEnd(40), chalk.yellow(process.env.WEBPACK_DEVTOOL))