fix(transformer): Use healthEndpoint if defined when transforming a server port #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmichel1
changed the title
If a custom healthEndpoint is defined it should be used otherwise k8s will never mark the node as ready.
I encountered this bug with the below config.
```yaml
profiles:
gate:
servlet:
context-path: /api/v1
service-settings:
gate:
healthEndpoint: /api/v1/health
server:
port: 9002
default:
apiPort: 8085
legacyServerPort: 8084
```
Related to spinnaker/spinnaker#2533
dmichel1
force-pushed
the
dmichel/custom-health
branch
from
7da7b80 to
f431286
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a custom healthEndpoint is defined it should be used otherwise k8s will never mark the node as ready.
I encountered this bug with the below config. Its using a custom context-path and a legacy server port.
Related to spinnaker/spinnaker#2533