-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use healthEndpoint if defined when transforming a server port
If a custom healthEndpoint is defined it should be used otherwise k8s will never mark the node as ready. I encountered this bug with the below config. ```yaml profiles: gate: servlet: context-path: /api/v1 service-settings: gate: healthEndpoint: /api/v1/health server: port: 9002 default: apiPort: 8085 legacyServerPort: 8084 ``` Related to spinnaker/spinnaker#2533
- Loading branch information
Showing
3 changed files
with
44 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
23 changes: 23 additions & 0 deletions
23
pkg/deploy/spindeploy/transformer/testdata/spinsvc_profile_health_endpoint.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,23 @@ | ||
apiVersion: spinnaker.io/v1alpha2 | ||
kind: SpinnakerService | ||
metadata: | ||
name: spinnaker | ||
namespace: ns1 | ||
spec: | ||
spinnakerConfig: | ||
config: | ||
version: 1.15.1 | ||
persistentStorage: | ||
persistentStoreType: s3 | ||
s3: | ||
bucket: my-bucket | ||
region: us-west-2 | ||
rootFolder: front50 | ||
profiles: | ||
gate: | ||
healthEndpoint: /api/v1/health | ||
server: | ||
port: 1111 | ||
status: | ||
apiUrl: http://acme.com | ||
uiUrl: http://acme.com |