-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor UInt{8,16,64,128}
into one struct UInt
#121
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
I wonder whether we could completely get rid of uint8
module?
To preserve+ the functionality, it would require the UInt<const N: usize, T: PrimInt + Debug, F: Field>
struct to implement new_input_vec
, which would in turn require an extra trait bound T: ToConstraintField
. These seem like natural things to have for u16
etc. anyway.
This could easily be a follow-up PR though, but if you agree then let's open an issue for tracking.
Unfortunately I think there's a special impl of |
Rather than generalizing we could just implement |
66be56c
to
e8f8b3b
Compare
b257da7
to
276979d
Compare
@Pratyush After moving It was previously enough to |
Description
closes: #116
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the Github PR explorer