Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back ToBytesGadget and ToBitsGadget to prelude #136

Merged
merged 8 commits into from
Jan 6, 2024

Conversation

Pratyush
Copy link
Member

@Pratyush Pratyush commented Jan 3, 2024

Description

  • Fixes Refactor UInt{8,16,64,128} into one struct UInt #121 (comment)
  • Add {BitAnd,BitOr,BitXor,BitAndAssign,BitOrAssign,BitXorAssign}<T> for UInt<N, T, F>
  • Add UInt::rotate_{left,right}_in_place
  • Add {Boolean,UInt}::not_in_place
  • Rename ToBytesGadget::to_{non_unique_}bytesToBytesGadget::to_{non_unique_}bytes_in_le

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@Pratyush Pratyush requested a review from a team as a code owner January 3, 2024 17:44
@Pratyush Pratyush requested review from z-tech, mmagician and weikengchen and removed request for a team January 3, 2024 17:44
@Pratyush Pratyush force-pushed the add-convert-traits-to-prelude branch from 7e0d792 to 439d55c Compare January 3, 2024 20:03
src/uint/and.rs Show resolved Hide resolved
src/uint/and.rs Show resolved Hide resolved
src/uint/not.rs Show resolved Hide resolved
src/uint/or.rs Show resolved Hide resolved
src/uint/or.rs Show resolved Hide resolved
src/uint/xor.rs Show resolved Hide resolved
src/uint/and.rs Show resolved Hide resolved
@Pratyush Pratyush merged commit a124995 into master Jan 6, 2024
5 of 11 checks passed
@Pratyush Pratyush deleted the add-convert-traits-to-prelude branch January 6, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants