Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): switch from js-yaml to yaml. Fixes #12205 #13750

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(ui): switch from js-yaml to yaml. Fixes #12205 #13750

merged 1 commit into from
Oct 14, 2024

Commits on Oct 13, 2024

  1. fix(ui): switch from js-yaml to yaml. Fixes argoproj#12205 

    [js-yaml](https://www.npmjs.com/package/js-yaml) has had no releases in
over 3 years. Also, the fact it only supports YAML 1.2 is leading to
bugs, since Kubernetes uses YAML 1.1 (see
kubernetes/kubernetes#34146).

This switches over to [yaml](https://www.npmjs.com/package/yaml), which
had a release last month, is [licensed under
ISC](https://github.com/eemeli/yaml/blob/main/LICENSE), and supports
YAML 1.1. I also added test cases for the parsing/stringifying code.

Signed-off-by: Mason Malone <[email protected]>
    @MasonM
    MasonM committed Oct 13, 2024
    Configuration menu
    Copy the full SHA
    1693f40 View commit details
    Browse the repository at this point in the history