fix(ui): switch from js-yaml to yaml. Fixes #12205
#13750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MasonM
force-pushed
the
fix-12205-switch-js-yaml
branch
from
f165571
to
8317301
Compare
[js-yaml](https://www.npmjs.com/package/js-yaml) has had no releases in over 3 years. Also, the fact it only supports YAML 1.2 is leading to bugs, since Kubernetes uses YAML 1.1 (see kubernetes/kubernetes#34146). This switches over to [yaml](https://www.npmjs.com/package/yaml), which had a release last month, is [licensed under ISC](https://github.com/eemeli/yaml/blob/main/LICENSE), and supports YAML 1.1. I also added test cases for the parsing/stringifying code. Signed-off-by: Mason Malone <[email protected]>
MasonM
force-pushed
the
fix-12205-switch-js-yaml
branch
from
8317301
to
1693f40
Compare
agilgur5
changed the title
js-yaml to yaml. Fixes #12205
agilgur5
added
type/dependencies
agilgur5
reviewed
Oct 14, 2024
There was a problem hiding this comment.
For reference, js-yaml was not removed from the yarn.lock as it's still used by some devDeps like ESLint and Istanbul, and also by the Swagger UI.
agilgur5
reviewed
Oct 28, 2024
There was a problem hiding this comment.
It looks like yaml is a decent bit bigger than js-yaml (noticed while doing bundle analysis for #12611). We may want to consider a smaller dep or code-splitting out its usage a la #12059
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12205
Motivation
js-yaml has had no releases in over 3 years. Also, the fact it only supports YAML 1.2 is leading to bugs, since Kubernetes uses YAML 1.1 (see kubernetes/kubernetes#34146).
Modifications
This switches over to yaml, which had a release last month, is licensed under ISC, and supports YAML 1.1. I also added test cases for the parsing/stringifying code.
Verification
Copied the example from #12205 over to http://localhost:8080/workflow-templates and verified the
mode: 0755was changed tomode: 493:fix-12205.mp4