Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sqlite-based memory store for live workflows. Fixes #12025 #13021

Merged
merged 45 commits into from
May 11, 2024
Merged

feat: add sqlite-based memory store for live workflows. Fixes #12025 #13021

merged 45 commits into from
May 11, 2024

Conversation

jiachengxu
Copy link
Member

@jiachengxu jiachengxu commented May 8, 2024 •
edited
Loading

Fixes: #12025
Implementation of the proposal: #12025 (comment)
Orginal PR: #12736, and was reverted to fix the CI, and this commit fixes the CI issue.

@jiachengxu
feat: add sqlite-based memory store for live workflows
8793b7a 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: lint
55cd632 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore(test): update the test
3f76d4f 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore(test): try to set cgo enabled for go sqlite
bdb010d 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: remove direct use of go-sqlite3
a451490 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: add build-base to use cgo in builder image
e6d3d25 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: small fix for test
3eac5a4 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: get rid of cgo
abc06d3 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: revert the makefile change
ae50e97 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: revert the makefile change
05e4029 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore: update
c944a61 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: lint
f322316 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
chore(stage): add test
f00720d 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge branch 'main' into list-workflow
2f0e02e
@jiachengxu
chore(stage): fix lint
9647006 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
feat: implement pagination
85665e3 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: unit test
e0df0ff 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: lint
bafa4f1 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge branch 'main' into list-workflow
9883a3c
@jiachengxu
fix: e2e test
b2b4fe2 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge branch 'main' into list-workflow
c0b8d84
@jiachengxu
Merge branch 'main' into list-workflow
ee14a1b
@jiachengxu
Merge remote-tracking branch 'upstream/main' into list-workflow
fe68611 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge remote-tracking branch 'refs/remotes/origin/list-workflow' into…
06fb1c7 
… list-workflow

Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge branch 'main' into list-workflow
9873620
@jiachengxu
fix: imports
c245e69 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: load entire archived workflow into memory in list APIs
fd5f9da 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
fix: add support for mysql
8dc8d1a 
Signed-off-by: Jiacheng Xu <[email protected]>
@jiachengxu
Merge branch 'main' into list-workflow
f2552ad
@jiachengxu
Merge branch 'select-archived-workflow-fix' into list-workflow
de457f6 
Signed-off-by: Jiacheng Xu <[email protected]>
terrytangyuan
terrytangyuan approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this is a clone of previous PR except for one additional merge commit so LGTM as long as the CI is passing.

@agilgur5 agilgur5 added area/api Argo Server API area/server labels May 8, 2024
@agilgur5 agilgur5 added this to the v3.5.x patches milestone May 8, 2024
@jiachengxu jiachengxu marked this pull request as ready for review May 9, 2024 16:19
@terrytangyuan terrytangyuan merged commit 0a096e6 into argoproj:main May 11, 2024
30 checks passed
@agilgur5 agilgur5 mentioned this pull request May 11, 2024
Merged
@Joibel
Copy link
Member

Joibel commented May 11, 2024

Thanks @jiachengxu for sorting it so quickly and to @terrytangyuan for merging.

@terrytangyuan terrytangyuan mentioned this pull request May 16, 2024
Open
agilgur5 pushed a commit that referenced this pull request May 27, 2024
@jiachengxu @agilgur5
feat: add sqlite-based memory store for live workflows. Fixes #12025 (#…
a6fec41 
…13021)

Signed-off-by: Jiacheng Xu <[email protected]>
Co-authored-by: Anton Gilgur <[email protected]>
(cherry picked from commit 0a096e6)
@agilgur5
Copy link
Contributor

Backported into release-3.5 as a6fec41

This was referenced May 28, 2024
Closed
Closed
@Joibel Joibel mentioned this pull request Jun 5, 2024
Closed
4 tasks
This was referenced Jun 6, 2024
Closed
Closed
Open
Closed
@jiachengxu jiachengxu deleted the list-workflow-2 branch June 14, 2024 16:45
@agilgur5 agilgur5 mentioned this pull request Jun 22, 2024
Closed
4 tasks
@terrytangyuan terrytangyuan mentioned this pull request Aug 2, 2024
Closed
@Joibel Joibel mentioned this pull request Sep 6, 2024
Open
4 tasks
@agilgur5 agilgur5 mentioned this pull request Sep 7, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees
No one assigned
Labels
area/api Argo Server API area/server
Projects
None yet
Milestone
v3.5.x patches
Development

Successfully merging this pull request may close these issues.

3.5 ListWorkflows causes server to hang when there are lots of archived workflows
4 participants
@jiachengxu @Joibel @agilgur5 @terrytangyuan