refactor(deps): remove moment dep and usage
#12611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
7 tasks
19 tasks
8 tasks
This was finally merged in late August, so this PR can now be finalized |
agilgur5
force-pushed
the
refactor-deps-remove-moment
branch
from
34678ed
to
4c62f08
Compare
|
Apparently |
tczhao
approved these changes
Nov 4, 2024
`moment` has been [deprecated since Sep 2020](https://momentjs.com/docs/#/-project-status/) and recommends using native `Intl` or newer libraries that make use of native `Intl`, such as `luxon` and `dayjs` - `moment` is also a very large dependency and hence is ripe for pruning and replacement as well - replace all usage of `moment` with regular `Date` functions - `valueOf()` works the same way for `Date` and `moment` - `diff` doesn't exist, but it's a one-liner helper - `format` doesn't exist, but we can also use a simple helper for that - shave off X kb by replacing ~15 LoC Signed-off-by: Anton Gilgur <[email protected]>
Signed-off-by: Anton Gilgur <[email protected]>
agilgur5
force-pushed
the
refactor-deps-remove-moment
branch
from
41d4fa4
to
3c33a21
Compare
|
Fixed conflicts |
Joibel
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Anton Gilgur <[email protected]> (cherry picked from commit 2f3d6a6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix for #12059, but removing / replacing a large dep entirely.
chart.jsin the deps, so it instead got code-split into theReportspage bundle, see "Notes to Reviewers" belowFollow-up to #12097
Motivation
momenthas been deprecated since Sep 2020 and recommends using nativeIntlor newer libraries that make use of nativeIntl, such asluxonandday.jsmomentis also a very large dependency and hence is ripe for pruning and replacement as wellshave off ~634KB / 260KB minified / 73KB gzipped from the main bundle by replacing ~15 LoC
Modifications
replace all usage of
momentwith regularDatefunctionsvalueOf()works the same way forDateandmomentdiffdoesn't exist, but it's a one-liner helperformatdoesn't exist, but we can also use a simple helper for thatUpdate
argo-uito latest include refactor(deps)!: removemomentdep and usage argo-ui#535. See full diff: argoproj/argo-ui@6de6bfe...54f36c7Verification
make start UI=trueView a specific node of a workflow;
workflow-node-infolooks correct to me. Screenshot:Bundle Analysis
before:
after:
Notes to Reviewers
momentwas removed as a dep in this PR from our own usage and fromargo-ui's usage (argoproj/argo-ui#535), but apparently it is still depended on by the old version ofchart.jsin the deps, so it got code-split out to theReportsbundle from #12061.Future Work
chart.jsandreact-chartjs-2to more modern versions with tree-shaking and no direct dependence onmoment