remove xml handling

apimatic · Jun 27, 2024 · 85c0966 · 85c0966
1 parent a706549
commit 85c0966
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/packages/schema/src/types/object.ts b/packages/schema/src/types/object.ts
@@ -468,11 +468,11 @@ function mapObject<T extends AnyObjectSchema>(
       unknownKeys.delete(propName);
 
       if (isOptionalNullable(element[1].type(), propValue)) {
-        if (typeof value === 'undefined') {
+        if (typeof propValue === 'undefined') {
           // Skip mapping to avoid creating properties with value 'undefined'
           continue;
         }
-        output[key] = propValue;
+        output[key] = null;
         continue;
       }
 

diff --git a/packages/schema/test/types/object.test.ts b/packages/schema/test/types/object.test.ts
@@ -20,15 +20,22 @@ describe('Object', () => {
     });
 
     const workSchema = object({
-      id: ['work_id', optional(nullable(string()))],
+      id: ['work_id', optional(nullable(number()))],
+      name: ['work_name', optional(nullable(string()))],
+      address: ['work_address', optional(nullable(string()))],
     });
 
+    // null => null
+    // undefined => missing
+    // missing => missing
+
     it('should map valid object with lazy loaded sub object', () => {
       const input = {
         user_id: 'John Smith',
         user_age: 50,
         user_work: {
           work_id: null,
+          work_name: undefined,
         },
       };
       const output = validateAndMap(input, userSchema);