remove xml handling

apimatic · Jun 27, 2024 · a706549 · a706549
1 parent 3352fb2
commit a706549
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 6 deletions.
diff --git a/packages/schema/src/schema.ts b/packages/schema/src/schema.ts
@@ -142,17 +142,14 @@ export function validateAndUnmap<T extends Schema<any, any>>(
  * @param schema Schema for type
  */
 export function validateAndMapXml<T extends Schema<any, any>>(
-  value: SchemaMappedType<T>,
+  value: unknown,
   schema: T
 ): ValidationResult<SchemaType<T>> {
   const contextCreator = createSchemaContextCreator(
     createNewSchemaContext(value, schema.type())
   );
   const validationResult = schema.validateBeforeMapXml(value, contextCreator);
   if (validationResult.length === 0) {
-    if (isOptionalNullable(schema.type(), value)) {
-      return { errors: false, result: value };
-    }
     return { errors: false, result: schema.mapXml(value, contextCreator) };
   } else {
     return { errors: validationResult };

diff --git a/packages/schema/src/types/nullable.ts b/packages/schema/src/types/nullable.ts
@@ -22,7 +22,7 @@ export function nullable<T, S>(
     validateBeforeMapXml: (value, ctxt) =>
       value === null ? [] : schema.validateBeforeMapXml(value, ctxt),
     mapXml: (value, ctxt) =>
-      isNullOrMissing(value) ? null : schema.mapXml(value, ctxt),
+      value === null ? null : schema.mapXml(value, ctxt),
     unmapXml: (value, ctxt) =>
       value === null ? null : schema.unmapXml(value, ctxt),
   };

diff --git a/packages/schema/src/types/optional.ts b/packages/schema/src/types/optional.ts
@@ -27,7 +27,7 @@ export function optional<T, S>(
         ? []
         : schema.validateBeforeMapXml(value, ctxt),
     mapXml: (value, ctxt) =>
-      isNullOrMissing(value) ? undefined : schema.mapXml(value, ctxt),
+      value === null ? undefined : schema.mapXml(value, ctxt),
     unmapXml: (value, ctxt) =>
       typeof value === 'undefined' ? undefined : schema.unmapXml(value, ctxt),
   };