Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starknet: fix Event.address name #117

Merged
merged 2 commits into from
Nov 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "starknet: fix Event.address name",
"packageName": "@apibara/starknet",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/apibara-0b94ab9f-bbed-4132-9114-27954f11f06e.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "cli: remove unused dev argument",
"packageName": "apibara",
"email": "[email protected]",
"dependentChangeType": "patch"
}
5 changes: 0 additions & 5 deletions packages/cli/src/cli/commands/dev.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,6 @@ export default defineCommand({
type: "string",
description: "Preset to use",
},
sink: {
type: "string",
description: "Sink to use",
},
},
async run({ args }) {
const rootDir = resolve((args.dir || args._dir || ".") as string);
Expand Down Expand Up @@ -103,7 +99,6 @@ export default defineCommand({
"start",
...(args.indexers ? ["--indexers", args.indexers] : []),
...(args.preset ? ["--preset", args.preset] : []),
...(args.sink ? ["--sink", args.sink] : []),
];

childProcess = spawn("node", childArgs, {
Expand Down
2 changes: 1 addition & 1 deletion packages/starknet/proto/data.proto
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,7 @@ message DeployAccountTransactionReceipt { FieldElement contract_address = 1; }
message Event {
repeated uint32 filter_ids = 1;
// The contract that emitted the event.
FieldElement from_address = 2;
FieldElement address = 2;
// The event keys.
repeated FieldElement keys = 3;
// The event data.
Expand Down
20 changes: 10 additions & 10 deletions packages/starknet/src/proto/data.ts

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.