Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

starknet: fix Event.address name #117

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

fracek
Copy link
Contributor

@fracek fracek commented Nov 29, 2024

No description provided.

Copy link

coderabbitai bot commented Nov 29, 2024

📝 Walkthrough
📝 Walkthrough

Walkthrough

This pull request introduces a new JSON file for the @apibara/starknet package, specifying a prerelease version with a comment about fixing the Event.address naming. Additionally, it modifies the data.proto and data.ts files by renaming the from_address field to address in the Event message, ensuring consistency across the codebase. The fromAddress property in the Event interface is also renamed to address, and a similar change is made for the MessageToL1 interface. The sink argument is removed from the CLI command in dev.ts.

Changes

File Path Change Summary
change/@apibara-starknet-c217b598... New metadata entry added for prerelease version, addressing Event.address naming issue.
packages/starknet/proto/data.proto Renamed field from_address to address in Event message.
packages/starknet/src/proto/data.ts Renamed property fromAddress to address in Event interface; renamed fromAddress to toAddress in MessageToL1 interface. Updated encoding and decoding methods accordingly.
packages/cli/src/cli/commands/dev.ts Removed sink argument from command definition in dev.ts.

Possibly related PRs

  • Update DNA definitions #101: This PR introduces new JSON files for various packages, including @apibara/starknet, which is directly related to the main PR's changes in the @apibara/starknet package.
  • Prepare for release #102: This PR includes changes to the release workflow and mentions updates to JSON files for prerelease versions, which aligns with the main PR's focus on a new JSON file for @apibara/starknet.
  • ci: fix release workflow #103: Similar to Prepare for release #102, this PR modifies the release workflow and is relevant due to its connection to the management of package versions, which is a theme in the main PR.
  • indexer: update drizzle and drizzle sink #107: This PR introduces a new JSON file for @apibara/indexer, which is relevant as it also deals with the introduction of a new JSON file for a package, similar to the main PR.
  • indexer: add hooks for each message type #112: This PR adds a new JSON file for @apibara/indexer, indicating a prerelease, which is consistent with the main PR's introduction of a JSON file for @apibara/starknet.
  • cli: include runtime-meta in package #114: This PR introduces a JSON file for the apibara package, which is relevant as it also specifies metadata for a prerelease version, similar to the main PR.
  • Fix minor issues with CLI #115: This PR includes a JSON file for the apibara package, which is relevant due to its focus on metadata for a prerelease version, aligning with the main PR's changes.

Suggested reviewers

  • jaipaljadeja

Poem

🐇 In the meadow where changes bloom,
A new name brings away the gloom.
From from_address to address bright,
Events now shine with clearer light.
Hopping along, we celebrate,
For every fix, we elevate! 🌼


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between d980659 and a27f0b7.

📒 Files selected for processing (2)
  • change/apibara-0b94ab9f-bbed-4132-9114-27954f11f06e.json (1 hunks)
  • packages/cli/src/cli/commands/dev.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • packages/cli/src/cli/commands/dev.ts
✅ Files skipped from review due to trivial changes (1)
  • change/apibara-0b94ab9f-bbed-4132-9114-27954f11f06e.json

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@fracek fracek requested a review from jaipaljadeja November 29, 2024 09:36
@fracek fracek force-pushed the fix-starknet-protocol branch from d980659 to a27f0b7 Compare November 29, 2024 12:27
Copy link
Member

@jaipaljadeja jaipaljadeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jaipaljadeja jaipaljadeja merged commit 0d87c0c into apibara:main Nov 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants