fix: Fix ByteBuf leak in remoting transport. #1635
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
requested review from
alexandru,
pjfanning,
jrudolph,
raboof,
gmethvin,
nvollmar,
mdedetrich and
Roiocam
pjfanning
reviewed
Dec 28, 2024
multi-node-testkit/src/main/scala/org/apache/pekko/remote/testconductor/RemoteConnection.scala
Outdated
Show resolved
Hide resolved
This was referenced Dec 28, 2024
jxnu-liguobin
approved these changes
Dec 28, 2024
He-Pin
commented
Dec 28, 2024
| log.warning("Error while handling message from [{}]: {}", ctx.channel().remoteAddress(), e) | ||
| onException(ctx, e) | ||
| } finally { | ||
| msg.release() |
There was a problem hiding this comment.
I can't call release, because it's a retainedSlice not a readRetainedSlice, will dig it deeper
|
I would prefer if the exception handling changes were tracked separately - separate issue with a description of why the existing exception handling is wrong - and separate PR. I think this PR should just add the finally block with the buffer release. That is all that highlighted as wrong in the issue. |
|
OK, Will split |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1634
Modification:
Call
byteBuf.releaseafter bytes read.Result:
No leaks.
Sorry for everyone.
It's using
retainedSliceinLengthFieldBasedFrameDecoder