fix: Fix ByteBuf leak in remoting transport. #1636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
requested review from
pjfanning,
gmethvin,
mdedetrich,
jrudolph,
raboof,
nvollmar,
Roiocam and
laglangyue
He-Pin
force-pushed
the
1.1.x-leakFix
branch
from
e848065 to
d390ae1
Compare
|
changed back to main branch - the PR was messed up when it was set to merge to 1.1.x branch and would have brought lots of unrelated changes |
He-Pin
force-pushed
the
1.1.x-leakFix
branch
from
d390ae1 to
e9fa693
Compare
|
This should not be attempted while #1635 is in progress. We need 1 PR to review, not 2. We can get 1 PR right and look into backporting when the first PR is right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
refs: #1634
Modification:
Call byteBuf.release after bytes read.
Result:
No leaks.
Sorry for everyone.
It's using retainedSlice in LengthFieldBasedFrameDecoder