Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run extra tests that need Java 9+ #1434

Merged
merged 1 commit into from
Aug 9, 2024
Merged

run extra tests that need Java 9+ #1434

merged 1 commit into from
Aug 9, 2024

Conversation

pjfanning
Copy link
Contributor

related to #1433

raboof
raboof approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good observation that we were missing those.

(FWIW I'd also be OK with running all the tests under Java 21: any bugs that'd only pop up when running under Java 8 should be picked up by the nightlies)

@pjfanning
Copy link
Contributor Author

I'd prefer to keep the Java 21 run separate, for now. We can optimise the build later. I suspect at some stage, we will be requested to cut down on CI build time.

@pjfanning pjfanning merged commit e1b4915 into apache:main Aug 9, 2024
19 checks passed
@pjfanning pjfanning deleted the java-21-testing branch August 9, 2024 16:04
@pjfanning pjfanning mentioned this pull request Aug 9, 2024
Merged
@Roiocam
Copy link
Member

Roiocam commented Aug 14, 2024

Thanks for this, It looks like a new case that we didn't cover it.
we haven't jdk9 test before, only exists in documentation.

@pjfanning pjfanning mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pjfanning @Roiocam @raboof