Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jdk9 tests do not run #1433

Closed
pjfanning opened this issue Aug 8, 2024 · 2 comments
Closed

jdk9 tests do not run #1433

pjfanning opened this issue Aug 8, 2024 · 2 comments

Comments

@pjfanning
Copy link
Contributor

See #1432 - I deliberately modified 2 classes (1 Java, 1 Scala) to see if they were even compiled. The PR did fail because scalafmt and the doc build failed but the main part of the build where we compile code and run tests - this all ran ok.

@Roiocam
Copy link
Member

Roiocam commented Aug 9, 2024

I guess sbt dependWalkerCheck didn't want to verify TestJDK9+ classes compile, but I don't remember why it was on purpose.

and it is normal that PRValidationTest does not run JDK9 verification. We will not verify these on the main process, but only verify on binary compability or documentation check

@pjfanning
Copy link
Contributor Author

#1434 merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants