Code cleanups and warnings #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the nice cleanup, +1. |
|
I like very much the cleanup. However, I see some changes in the code of RandomRBFGeneratorEvents, Can you explain why these changes are needed? Thanks! |
asfgit
force-pushed
the
master
branch
2 times, most recently
from
f9db1f2 to
1bd1012
Compare
csterling
approved these changes
Nov 18, 2019
@abifet It seems to me that the code changes you mentioned are the removal of dead code branches (i.e. the conditions are impossible to satisfy). |
@csterling Thanks! +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.