Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Add golden files for test #150

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Conversation

snmvaughan
Copy link
Contributor

Which issue does this PR close?

Closes #149.

Rationale for this change

The test has already been implemented, but the golden files were missing.

What changes are included in this PR?

The missing golden files for running the unit test are added, and the test is re-enabled.

How are these changes tested?

Running the existing test

@sunchao sunchao merged commit 23c748b into apache:main Mar 1, 2024
13 checks passed
@sunchao
Copy link
Member

sunchao commented Mar 1, 2024

Merged, thanks @snmvaughan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore unit test for panic stacktrace in exception
2 participants