Skip to content

Commit

Permalink
test: Add golden files for test (#150)
Browse files Browse the repository at this point in the history
Co-authored-by: Steve Vaughan <[email protected]>
  • Loading branch information
snmvaughan and Steve Vaughan authored Mar 1, 2024
1 parent 1f53e25 commit 23c748b
Show file tree
Hide file tree
Showing 3 changed files with 34 additions and 1 deletion.
1 change: 0 additions & 1 deletion core/src/errors.rs
Original file line number Diff line number Diff line change
Expand Up @@ -651,7 +651,6 @@ mod tests {
/// See [`object_panic_exception`] for a test which involves generating a panic and verifying
/// that the resulting stack trace includes the offending call.
#[test]
#[ignore]
pub fn stacktrace_string() {
// Setup: Start with a backtrace that includes all of the expected scenarios, including
// cases where the file and location are not provided as part of the backtrace capture
Expand Down
22 changes: 22 additions & 0 deletions core/testdata/backtrace.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
0: std::backtrace_rs::backtrace::libunwind::trace
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93:5
1: std::backtrace_rs::backtrace::trace_unsynchronized
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/../../backtrace/src/backtrace/mod.rs:66:5
2: std::backtrace::Backtrace::create
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/backtrace.rs:331:13
3: std::backtrace::Backtrace::capture
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/backtrace.rs:297:9
4: comet::Java_org_apache_comet_NativeBase_init::{{closure}}
at /Users/somebody/src/arrow-datafusion-comet/core/src/lib.rs:70:77
5: std::panicking::try::do_call
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panicking.rs:526:40
6: ___rust_try
7: std::panicking::try
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panicking.rs:490:19
8: std::panic::catch_unwind
at /rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panic.rs:142:14
9: comet::errors::try_unwrap_or_throw
at /Users/somebody/src/arrow-datafusion-comet/core/src/errors.rs:369:43
10: Java_org_apache_comet_NativeBase_init
at /Users/somebody/src/arrow-datafusion-comet/core/src/lib.rs:53:5

12 changes: 12 additions & 0 deletions core/testdata/stacktrace.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
Some Error Message
at std::backtrace_rs::backtrace::libunwind::trace(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/../../backtrace/src/backtrace/libunwind.rs:93)
at std::backtrace_rs::backtrace::trace_unsynchronized(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/../../backtrace/src/backtrace/mod.rs:66)
at std::backtrace::Backtrace::create(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/backtrace.rs:331)
at std::backtrace::Backtrace::capture(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/backtrace.rs:297)
at comet::Java_org_apache_comet_NativeBase_init::{{closure}}(/Users/somebody/src/arrow-datafusion-comet/core/src/lib.rs:70)
at std::panicking::try::do_call(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panicking.rs:526)
at ___rust_try(__internal__:0)
at std::panicking::try(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panicking.rs:490)
at std::panic::catch_unwind(/rustc/ec08a0337f3556212525dbf1d3b41e19bdf27621/library/std/src/panic.rs:142)
at comet::errors::try_unwrap_or_throw(/Users/somebody/src/arrow-datafusion-comet/core/src/errors.rs:369)
at Java_org_apache_comet_NativeBase_init(/Users/somebody/src/arrow-datafusion-comet/core/src/lib.rs:53)

0 comments on commit 23c748b

Please sign in to comment.