You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During debugging some test failures in #437, I found that CometScanExec returns empty dictionary values after first batch in failed queries. It is because in Data.importVector API call, it will release existing dictionary vector in the given dictionaryProvider and re-import the dictionary vector.
Currently we only initiate CometDictionary at the first batch and reuse it for later batches. Because of above issue, we should already initiate CometDictionary. It is simply re-importing existing dictionary vector allocated by native side, so it doesn't incur re-allocation of memory.
Steps to reproduce
No response
Expected behavior
No response
Additional context
No response
The text was updated successfully, but these errors were encountered:
Describe the bug
During debugging some test failures in #437, I found that
CometScanExec
returns empty dictionary values after first batch in failed queries. It is because inData.importVector
API call, it will release existing dictionary vector in the givendictionaryProvider
and re-import the dictionary vector.Currently we only initiate
CometDictionary
at the first batch and reuse it for later batches. Because of above issue, we should already initiateCometDictionary
. It is simply re-importing existing dictionary vector allocated by native side, so it doesn't incur re-allocation of memory.Steps to reproduce
No response
Expected behavior
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: