fix: ColumnReader.loadVector should initiate CometDictionary after re-import arrays
#473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @sunchao |
…r re-import arrays
viirya
force-pushed
the
fix_columnar_reader
branch
from
377982a to
9a2a851
Compare
viirya
commented
May 25, 2024
| CometPlainVector dictionaryVector = | ||
| new CometPlainVector(arrowDictionary.getVector(), useDecimal128, isUuid); | ||
| dictionary = new CometDictionary(dictionaryVector); | ||
|
|
There was a problem hiding this comment.
The test failure is in TPCDSQuerySuite in #437. I don't have a simple reproducible test case for it. But I think the change is straightforward and safe.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=========================================
Coverage 34.05% 34.05%
Complexity 859 859
=========================================
Files 116 116
Lines 38680 38679 -1
Branches 8568 8567 -1
=========================================
Hits 13171 13171
+ Misses 22746 22745 -1
Partials 2763 2763 ☔ View full report in Codecov by Sentry. |
andygrove
approved these changes
May 25, 2024
sunchao
approved these changes
May 25, 2024
|
Merged. Thanks @andygrove @sunchao |
|
@viirya Just fyi, this commit caused a large regression for me in local runs of TPC-H. I will share full details tomorrow. before
after
|
|
I got the reason why it has regression. I will propose a fix. |
himadripal
pushed a commit
to himadripal/datafusion-comet
that referenced
this pull request
Sep 7, 2024
…r re-import arrays (apache#473) (cherry picked from commit 5bfe46d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #474.
Rationale for this change
What changes are included in this PR?
How are these changes tested?