Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse previous CometDictionary Java arrays #488

Closed
viirya opened this issue May 28, 2024 · 0 comments · Fixed by #489
Closed

Reuse previous CometDictionary Java arrays #488

viirya opened this issue May 28, 2024 · 0 comments · Fixed by #489
Assignees
@viirya
Labels
bug Something isn't working

Comments

@viirya
Copy link
Member

viirya commented May 28, 2024

Describe the bug

After #474, ColumnReader.loadVector initiates CometDictionary after re-import arrays. It is reported by @andygrove (#473 (comment)) that after the patch, there is obvious regression when comparing with Spark.

It is because, although re-importing dictionary values is fast, CometDictionary has an initialization step to copy values from imported dictionary values to an internal Java array. We need to re-use previous CometDictionary's copied Java arrays.

Steps to reproduce

No response

Expected behavior

No response

Additional context

No response
@viirya viirya added the bug Something isn't working label May 28, 2024
@viirya viirya self-assigned this May 28, 2024
@viirya viirya mentioned this issue May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viirya viirya

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Reuse previous CometDictionary Java arrays viirya/arrow-datafusion-comet
1 participant
@viirya