Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml by using grpcio-tools==1.65.5 #32773

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Update pyproject.toml by using grpcio-tools==1.65.5 #32773

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3708e0
Update pyproject.toml
liferoad Oct 14, 2024
e47c261
use 1.65.5
liferoad Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sdks/python/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
"grpcio-tools==1.62.1",
Copy link
Contributor

@tvalentyn tvalentyn Oct 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are requirements for beam building environment (the environment where the whl files or sdist are built, ) ; this will not have an impact on dependency conflict you are resolving.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects the version of grpc compiler used to generate python stubs for grpc protos, and we cannot use the latest version due to incompatibilites.

RuntimeError: The grpc package installed is at version 1.65.5, but the generated code in org/apache/beam/model/pipeline/v1/metrics_pb2_grpc.py depends on grpcio>=1.66.2. Please upgrade your grpc module to grpcio>=1.66.2 or downgrade your generated code using grpcio-tools<=1.65.5.

I would keep it as is, we MIGHT have to bump this up due to protobuf upgrade but if we don't have to, I think we can keep as is.

We definitely cannot upgrade to grpcio>=1.66.2 while grpc/grpc#37710 is unresolved

cc: @jrmccluskey

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned this to 1.65.5. Seem working now.

"grpcio-tools==1.65.5",
"mypy-protobuf==3.5.0",
# Avoid https://github.com/pypa/virtualenv/issues/2006
"distlib==0.3.7",
Expand Down
Loading