-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pyproject.toml by using grpcio-tools==1.65.5 #32773
Conversation
@@ -21,7 +21,7 @@ | |||
requires = [ | |||
"setuptools", | |||
"wheel>=0.36.0", | |||
"grpcio-tools==1.62.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are requirements for beam building environment (the environment where the whl files or sdist are built, ) ; this will not have an impact on dependency conflict you are resolving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This affects the version of grpc compiler used to generate python stubs for grpc protos, and we cannot use the latest version due to incompatibilites.
RuntimeError: The grpc package installed is at version 1.65.5, but the generated code in org/apache/beam/model/pipeline/v1/metrics_pb2_grpc.py depends on grpcio>=1.66.2. Please upgrade your grpc module to grpcio>=1.66.2 or downgrade your generated code using grpcio-tools<=1.65.5.
I would keep it as is, we MIGHT have to bump this up due to protobuf upgrade but if we don't have to, I think we can keep as is.
We definitely cannot upgrade to grpcio>=1.66.2 while grpc/grpc#37710 is unresolved
cc: @jrmccluskey
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pinned this to 1.65.5. Seem working now.
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Assigning reviewers. If you would like to opt out of this review, comment R: @shunping for label python. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @tvalentyn WDYT?
Merge this for now. Will check the testing status tommorrow. |
We might have to increase the lower bound on grpcio dependency if we keep this bump, running an experiment in #32784 |
Got this message:
so, grpc wants to use the grpc version newer or equal than the version used to generate stubs. If we are to heed to these warnings, we should either bump the lower bound for grpc io, or revert this change (if this change didn't have intended impact). |
Do not need to pin down grpcio-tools:
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.