Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyproject.toml by using grpcio-tools==1.65.5 #32773

Merged
merged 2 commits into from
Oct 15, 2024
Merged

Conversation

liferoad
Copy link
Collaborator

@liferoad liferoad commented Oct 14, 2024

Do not need to pin down grpcio-tools:

pipdeptree   --reverse --packages grpcio
grpcio==1.65.5
├── apache-beam==2.61.0.dev0 [requires: grpcio>=1.33.1,<2,<1.66.0,!=1.62.1,!=1.62.0,!=1.61.*,!=1.60.*,!=1.59.*,!=1.48.0]
├── google-cloud-pubsub==2.26.0 [requires: grpcio>=1.51.3,<2.0dev]
│   └── google-cloud-pubsublite==1.11.1 [requires: google-cloud-pubsub>=2.10.0,<3.0.0dev]
├── google-cloud-pubsublite==1.11.1 [requires: grpcio>=1.38.1,<2.0.0dev]
├── grpc-google-iam-v1==0.13.1 [requires: grpcio>=1.44.0,<2.0.0dev]
│   ├── google-cloud-bigtable==2.26.0 [requires: grpc-google-iam-v1>=0.12.4,<1.0.0dev]
│   ├── google-cloud-dataproc==5.13.0 [requires: grpc-google-iam-v1>=0.12.4,<1.0.0dev]
│   ├── google-cloud-pubsub==2.26.0 [requires: grpc-google-iam-v1>=0.12.4,<1.0.0dev]
│   │   └── google-cloud-pubsublite==1.11.1 [requires: google-cloud-pubsub>=2.10.0,<3.0.0dev]
│   ├── google-cloud-resource-manager==1.12.5 [requires: grpc-google-iam-v1>=0.12.4,<1.0.0dev]
│   │   └── google-cloud-aiplatform==1.70.0 [requires: google-cloud-resource-manager>=1.3.3,<3.0.0dev]
│   └── google-cloud-spanner==3.49.1 [requires: grpc-google-iam-v1>=0.12.4,<1.0.0dev]
├── grpc-interceptor==0.15.4 [requires: grpcio>=1.49.1,<2.0.0]
│   └── google-cloud-spanner==3.49.1 [requires: grpc-interceptor>=0.15.4]
└── grpcio-status==1.65.5 [requires: grpcio>=1.65.5]
    ├── google-cloud-pubsub==2.26.0 [requires: grpcio-status>=1.33.2]
    │   └── google-cloud-pubsublite==1.11.1 [requires: google-cloud-pubsub>=2.10.0,<3.0.0dev]
    └── google-cloud-pubsublite==1.11.1 [requires: grpcio-status>=1.38.1,<2.0.0dev]

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@liferoad liferoad requested a review from tvalentyn October 14, 2024 21:06
@@ -21,7 +21,7 @@
requires = [
"setuptools",
"wheel>=0.36.0",
"grpcio-tools==1.62.1",
Copy link
Contributor

@tvalentyn tvalentyn Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are requirements for beam building environment (the environment where the whl files or sdist are built, ) ; this will not have an impact on dependency conflict you are resolving.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This affects the version of grpc compiler used to generate python stubs for grpc protos, and we cannot use the latest version due to incompatibilites.

RuntimeError: The grpc package installed is at version 1.65.5, but the generated code in org/apache/beam/model/pipeline/v1/metrics_pb2_grpc.py depends on grpcio>=1.66.2. Please upgrade your grpc module to grpcio>=1.66.2 or downgrade your generated code using grpcio-tools<=1.65.5.

I would keep it as is, we MIGHT have to bump this up due to protobuf upgrade but if we don't have to, I think we can keep as is.

We definitely cannot upgrade to grpcio>=1.66.2 while grpc/grpc#37710 is unresolved

cc: @jrmccluskey

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pinned this to 1.65.5. Seem working now.

Copy link
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

Copy link
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @shunping for label python.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Copy link
Contributor

@shunping shunping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @tvalentyn WDYT?

@liferoad
Copy link
Collaborator Author

Merge this for now. Will check the testing status tommorrow.

@liferoad liferoad merged commit 50f19d5 into master Oct 15, 2024
96 checks passed
@tvalentyn
Copy link
Contributor

We might have to increase the lower bound on grpcio dependency if we keep this bump, running an experiment in #32784

@tvalentyn tvalentyn deleted the liferoad-patch-1 branch October 15, 2024 15:29
@tvalentyn
Copy link
Contributor

Got this message:

packages/apache_beam/portability/api/org/apache/beam/model/job_management/v1/beam_expansion_api_pb2_grpc.py:21: RuntimeWarning: The grpc package installed is at version 1.58.3, but the generated code in org/apache/beam/model/job_management/v1/beam_expansion_api_pb2_grpc.py depends on grpcio>=1.65.5. Please upgrade your grpc module to grpcio>=1.65.5 or downgrade your generated code using grpcio-tools<=1.58.3. This warning will become an error in 1.66.0, scheduled for release on August 6, 2024.
    warnings.warn(

so, grpc wants to use the grpc version newer or equal than the version used to generate stubs. If we are to heed to these warnings, we should either bump the lower bound for grpc io, or revert this change (if this change didn't have intended impact).

@liferoad liferoad changed the title Update pyproject.toml Update pyproject.toml by using grpcio-tools==1.65.5 Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants