Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AAP-25503] Refactor instance tests #2716

Merged
merged 1 commit into from
Aug 27, 2024
Merged

[AAP-25503] Refactor instance tests #2716

merged 1 commit into from
Aug 27, 2024

Conversation

nixocio
Copy link
Contributor

@nixocio nixocio commented Jul 15, 2024 •
edited
Loading

Update instance tests and instance groups.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX E2E End-to-end testing labels Jul 15, 2024
@nixocio nixocio force-pushed the ui_add_instances branch 2 times, most recently from 782e667 to 26ebc17 Compare July 16, 2024 17:21
@nixocio nixocio force-pushed the ui_add_instances branch 2 times, most recently from 87217db to 0be7c2e Compare July 16, 2024 19:04
@nixocio nixocio changed the title [WIP] Test instances [AAP-25503] Refactor instance tests Jul 16, 2024
@nixocio nixocio force-pushed the ui_add_instances branch 2 times, most recently from 00622c9 to fbf81cf Compare July 16, 2024 19:17
@nixocio nixocio changed the title [AAP-25503] Refactor instance tests WIP [AAP-25503] Refactor instance tests Jul 16, 2024
@nixocio nixocio force-pushed the ui_add_instances branch 5 times, most recently from e906a46 to d6b81ae Compare July 22, 2024 17:29
@nixocio nixocio force-pushed the ui_add_instances branch 2 times, most recently from 8d012d0 to 9b7d45b Compare August 22, 2024 20:37
@nixocio nixocio changed the title WIP [AAP-25503] Refactor instance tests [AAP-25503] Refactor instance tests Aug 27, 2024
@nixocio nixocio mentioned this pull request Aug 27, 2024
Merged
@nixocio
[AAP-25503] Refactor instance tests
2a2ca7d 
Update instance tests and instance groups.
vidyanambiar
vidyanambiar reviewed Aug 27, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was also this failure locally in instances.cy.ts:
can run a health check on an Instance in the instance details page and assert the expected results
image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nixocio nixocio removed the dashboard label Aug 27, 2024
@nixocio
Copy link
Contributor Author

nixocio commented Aug 27, 2024

There was also this failure locally in instances.cy.ts: can run a health check on an Instance in the instance details page and assert the expected results image

I could not see that one. Trying again.

image

vidyanambiar
vidyanambiar approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed the flaky test will be separately addressed.

@nixocio nixocio merged commit 113f6ad into main Aug 27, 2024
48 of 59 checks passed
@nixocio nixocio deleted the ui_add_instances branch August 27, 2024 16:58
@nixocio nixocio mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vidyanambiar vidyanambiar vidyanambiar approved these changes

@jamestalton jamestalton Awaiting requested review from jamestalton

@akus062381 akus062381 Awaiting requested review from akus062381

@vishsanghishetty vishsanghishetty Awaiting requested review from vishsanghishetty

@AlexSCorey AlexSCorey Awaiting requested review from AlexSCorey

@keithjgrant keithjgrant Awaiting requested review from keithjgrant

@lgalis lgalis Awaiting requested review from lgalis

@ZitaNemeckova ZitaNemeckova Awaiting requested review from ZitaNemeckova

@marshmalien marshmalien Awaiting requested review from marshmalien

@kialam kialam Awaiting requested review from kialam

Assignees
No one assigned
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nixocio @vidyanambiar