Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary labels from spec files #3060

Merged
merged 6 commits into from
Aug 27, 2024

Conversation

akus062381
Copy link
Member

These labels aren't needed, because the files are listed in the excluded spec files in the applicable cypress config file.

@github-actions github-actions bot added AWX Label to indicate changes relevant to AWX EDA Label to indicate changes relevant to EDA E2E End-to-end testing labels Aug 27, 2024
@akus062381 akus062381 requested review from himdel and nixocio August 27, 2024 14:49
himdel
himdel previously approved these changes Aug 27, 2024
vidyanambiar
vidyanambiar previously approved these changes Aug 27, 2024
@vidyanambiar vidyanambiar dismissed their stale review August 27, 2024 15:22

Got some errors testing locally instanceGroups.cy.ts

@akus062381 akus062381 force-pushed the remove-unnecessary-upstream-labeling branch from a55433f to 17f93d6 Compare August 27, 2024 15:34
@github-actions github-actions bot added HUB AFW Ansible Framework labels Aug 27, 2024
vidyanambiar
vidyanambiar previously approved these changes Aug 27, 2024
Copy link
Member

@vidyanambiar vidyanambiar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@akus062381
Copy link
Member Author

@vidyanambiar do you mind reviewing again? I had to fix a conflict :-D

@akus062381 akus062381 force-pushed the remove-unnecessary-upstream-labeling branch from 00900a7 to 72bae9e Compare August 27, 2024 16:10
himdel
himdel previously approved these changes Aug 27, 2024
Copy link

@vidyanambiar vidyanambiar merged commit f4420a1 into main Aug 27, 2024
40 checks passed
@vidyanambiar vidyanambiar deleted the remove-unnecessary-upstream-labeling branch August 27, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AWX Label to indicate changes relevant to AWX E2E End-to-end testing EDA Label to indicate changes relevant to EDA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants