-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary labels from spec files #3060
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
AWX
Label to indicate changes relevant to AWX
EDA
Label to indicate changes relevant to EDA
E2E
End-to-end testing
labels
Aug 27, 2024
himdel
reviewed
Aug 27, 2024
nixocio
reviewed
Aug 27, 2024
cypress/e2e/awx/infrastructure/instance-groups/instanceGroups.cy.ts
Outdated
Show resolved
Hide resolved
nixocio
reviewed
Aug 27, 2024
himdel
previously approved these changes
Aug 27, 2024
vidyanambiar
previously approved these changes
Aug 27, 2024
vidyanambiar
dismissed
their stale review
August 27, 2024 15:22
Got some errors testing locally instanceGroups.cy.ts
cypress/e2e/awx/infrastructure/instance-groups/instanceGroups.cy.ts
Outdated
Show resolved
Hide resolved
cypress/e2e/awx/infrastructure/instance-groups/instanceGroups.cy.ts
Outdated
Show resolved
Hide resolved
akus062381
force-pushed
the
remove-unnecessary-upstream-labeling
branch
from
August 27, 2024 15:34
a55433f
to
17f93d6
Compare
vidyanambiar
previously approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
@vidyanambiar do you mind reviewing again? I had to fix a conflict :-D |
akus062381
force-pushed
the
remove-unnecessary-upstream-labeling
branch
from
August 27, 2024 16:10
00900a7
to
72bae9e
Compare
himdel
previously approved these changes
Aug 27, 2024
Quality Gate passedIssues Measures |
himdel
approved these changes
Aug 27, 2024
vidyanambiar
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These labels aren't needed, because the files are listed in the excluded spec files in the applicable cypress config file.