-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2024 April Update: Section 1.2.x Logic, Section 19 HKU Improvement, Handler Fixes, Prelim Fixes #100
Conversation
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
Signed-off-by: Frederick Witty <[email protected]>
@@ -26,7 +26,7 @@ | |||
# Current list is elastic and will be updated as we test more cloud based services. | |||
# Current testing is working in Azure using Hyper-V. We are currently using this for reference: | |||
# https://github.com/ansible/ansible/blob/905131fc76a07cf89dbc8d33e7a4910da3f10a16/lib/ansible/module_utils/facts/virtual/linux.py#L205 | |||
- name: Set Fact If Cloud-Based System. | |||
- name: PRELIM | Set Fact If Cloud-Based System. | |||
ansible.builtin.set_fact: | |||
win19cis_cloud_based_system: true | |||
when: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't the Azure fix be here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -26,7 +26,7 @@ | |||
# Current list is elastic and will be updated as we test more cloud based services. | |||
# Current testing is working in Azure using Hyper-V. We are currently using this for reference: | |||
# https://github.com/ansible/ansible/blob/905131fc76a07cf89dbc8d33e7a4910da3f10a16/lib/ansible/module_utils/facts/virtual/linux.py#L205 | |||
- name: Set Fact If Cloud-Based System. | |||
- name: PRELIM | Set Fact If Cloud-Based System. | |||
ansible.builtin.set_fact: | |||
win19cis_cloud_based_system: true | |||
when: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
when: | |
when: | |
- ansible_system_vendor == 'Microsoft Corporation' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you @georgenalen ! |
Overall Review of Changes:
Thank you @MrSteve81 for the enhancements to this release!
Issue Fixes:
Azure Cloud Logic for 1.2.x Section from @mfortin
Enhancements:
Improved Reboot Handler and SID user Logic for all local accounts
How has this been tested?:
Locally and Azure