Update Section 1 Logic, Section 19 Features Added, Handler Fixes, Prelim Fixes #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
MrSteve81
changed the title
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
Signed-off-by: Stephen Williams <[email protected]>
frederickw082922
added a commit
that referenced
this pull request
Apr 3, 2024
Signed-off-by: Frederick Witty <[email protected]>
mfortin
reviewed
Apr 4, 2024
| @@ -26,7 +26,7 @@ | |||
| # Current list is elastic and will be updated as we test more cloud based services. | |||
| # Current testing is working in Azure using Hyper-V. We are currently using this for reference: | |||
| # https://github.com/ansible/ansible/blob/905131fc76a07cf89dbc8d33e7a4910da3f10a16/lib/ansible/module_utils/facts/virtual/linux.py#L205 | |||
| - name: Set Fact If Cloud-Based System. | |||
| - name: PRELIM | Set Fact If Cloud-Based System. | |||
There was a problem hiding this comment.
This should only be done on Azure VMs. Amazon EC2 instances should stick with the default Section 01 order.
mfortin
reviewed
Apr 4, 2024
There was a problem hiding this comment.
https://github.com/ansible-lockdown/Windows-2019-CIS/pull/98/files#diff-23e21b6c89468f7534697ad091835b3ee5e0213b37ace489488234e5a9548ec4R765-R773
18.6.4.1 is defined twice and the one about DoH should be removed as there is no such control in Windows Server 2019
mfortin
reviewed
Apr 4, 2024
| ansible.builtin.set_fact: | ||
| windows_installation_type: "{{ get_windows_installation_type.value | default('') }}" | ||
| tags: | ||
| - always | ||
|
|
||
| - name: PRELIM | Obtatin And Load Default Hive As Well As User Hives |
There was a problem hiding this comment.
Suggested change
| - name: PRELIM | Obtatin And Load Default Hive As Well As User Hives | |
| - name: PRELIM | Obtain And Load Default Hive As Well As User Hives |
There was a problem hiding this comment.
Thank you @mfortin ! Nice catch!
|
Updates Moved to #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overall Review of Changes:
Update Section 1 Logic
Fixed prelim Tags
Updated Handlers
Issue Fixes:
Please list (using linking) any open issues this PR addresses
Enhancements:
Added Reboot Option And Section 19 Enhancement For Hives
How has this been tested?:
Please give an overview of how these changes were tested. If they were not please use N/A