Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue https://github.com/ansible-lockdown/AMAZON2023-CIS/issues/40 #41

Closed
wants to merge 28 commits into from
Closed

Fixing issue https://github.com/ansible-lockdown/AMAZON2023-CIS/issues/40 #41

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
6a3c7ec
Refactoring docs
DianaMariaDDM Feb 1, 2024
4a7ce35
Small fixings for https://code.siemens.com/infosec-pss-gov/security-c…
DianaMariaDDM Feb 14, 2024
c28b8a4
Removing trailing whitespace
DianaMariaDDM Feb 14, 2024
8bf9197
Fixing fail message so that is states the correct number of the rule …
DianaMariaDDM Feb 14, 2024
96c2ff2
Fixing tags for PRELIM task "PRELIM | capture /etc/password variables".
DianaMariaDDM Feb 15, 2024
f5ec60c
Fixing inconsistencies for issue https://code.siemens.com/infosec-pss…
DianaMariaDDM Feb 15, 2024
5593023
Fixing minor syntax issues by adding missing "PATCH" keywords or miss…
DianaMariaDDM Feb 15, 2024
9ee76ca
Fixing PRELIM task "PRELIM | 4.3.3 | Find all sudoers files" mentione…
DianaMariaDDM Feb 15, 2024
3bec70e
Removing 1.1.2.1 from multiline task 1.1.2.2 ,1.1.2.3, 1.1.2.4 becaus…
DianaMariaDDM Feb 15, 2024
e8f766f
Removing prelim for installing authconfig, as it is not used.
DianaMariaDDM Feb 16, 2024
e14d248
[pre-commit.ci] pre-commit autoupdate
pre-commit-ci[bot] Feb 19, 2024
a480622
Removing the 6.1.12 duplicate task and adding it to the 6.1.10 task a…
DianaMariaDDM Feb 21, 2024
f6e12ab
De-commenting allow and deny variables for sshd.
DianaMariaDDM Feb 21, 2024
5b2165d
Removing double import of cis_5.3.yml.
DianaMariaDDM Feb 22, 2024
fdd3c87
Merge pull request #18 from ansible-lockdown/pre-commit-ci-update-config
uk-bolly Feb 22, 2024
19a64e3
Merge pull request #35 from siemens/siemens/feat/new_docs
uk-bolly Feb 22, 2024
95c7f19
Merge pull request #39 from siemens/siemens/feat/ensure_root_psswd_fix
uk-bolly Feb 22, 2024
1c3bc34
Merge pull request #43 from siemens/siemens/feat/fixing_prelim_find_a…
uk-bolly Feb 22, 2024
283366c
Merge pull request #45 from siemens/siemens/feat/r_1.1.2.1
uk-bolly Feb 22, 2024
c9ce3e1
Merge pull request #47 from siemens/siemens/feat/fixing_inconsistencies
uk-bolly Feb 22, 2024
27f69f8
Merge pull request #49 from siemens/siemens/feat/minor_syntax_fixes
uk-bolly Feb 22, 2024
fb93017
Merge pull request #53 from siemens/siemens/feat/remove_6.1.12_duplicate
uk-bolly Feb 22, 2024
a452618
Merge pull request #55 from siemens/siemens/feat/fixing_double_import…
uk-bolly Feb 22, 2024
46b8d7d
Merge branch 'devel' into siemens/feat/removing_prelim_install_authco…
DianaMariaDDM Feb 23, 2024
66f73f5
Merge pull request #51 from siemens/siemens/feat/removing_prelim_inst…
uk-bolly Feb 23, 2024
e7c6f94
Fixing tags for PRELIM task "PRELIM | capture /etc/password variables".
DianaMariaDDM Feb 15, 2024
8601d63
Adding the appropriate tags for the PRELIM task.
DianaMariaDDM Feb 23, 2024
e6da846
Merge branch 'siemens/feat/fixing_tags_for_prelim_capture_etc_psswd' …
DianaMariaDDM Feb 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions tasks/prelim.yml
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch on this although we do need to ensure the correct tags are there for when individual tags are called to run just the one control.

rule_4.6.2
rule_6.2.10
users
accounts
or as its lightweight add the always tag?

Hope that makes sense

thanks

uk-bolly

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I think it's a good idea to add the always tag.

Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,6 @@
ansible.builtin.include_tasks:
file: parse_etc_password.yml
tags:
- rule_5.5.2
- rule_5.6.2
- rule_6.2.9
- rule_6.2.10
- rule_6.2.11
- amzn2023cis_section5
- amzn2023cis_section6
- level1-server

- name: "PRELIM | Interactive User accounts"
Expand Down
Loading