-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing issue https://github.com/ansible-lockdown/AMAZON2023-CIS/issues/40 #41
Fixing issue https://github.com/ansible-lockdown/AMAZON2023-CIS/issues/40 #41
Conversation
Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…that requires the root password to be set Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…ing "|". Signed-off-by: Diana-Maria Dumitru <[email protected]>
…e it was not supposed to be there! Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/gitleaks/gitleaks: v8.17.0 → v8.18.2](gitleaks/gitleaks@v8.17.0...v8.18.2) - [github.com/ansible-community/ansible-lint: v6.18.0 → v24.2.0](ansible/ansible-lint@v6.18.0...v24.2.0) - [github.com/adrienverge/yamllint.git: v1.32.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.35.1)
…s it was implementing something needed by 6.1.10. Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…it-ci-update-config [pre-commit.ci] pre-commit autoupdate
…docs Refactoring documentation
…re_root_psswd_fix Fixing ansible-lockdown#38
…ng_prelim_find_all_sudoers_files Fixing issue ansible-lockdown#42
…1.2.1 Fixing issue ansible-lockdown#44
…ng_inconsistencies Fixing issue ansible-lockdown#46
…r_syntax_fixes Fixing issue ansible-lockdown#48
…ve_6.1.12_duplicate Fixing issue ansible-lockdown#52
…ng_double_import_r_5_3 Removing double import of "cis_5.3.yml".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch on this although we do need to ensure the correct tags are there for when individual tags are called to run just the one control.
rule_4.6.2
rule_6.2.10
users
accounts
or as its lightweight add the always tag?
Hope that makes sense
thanks
uk-bolly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I think it's a good idea to add the always tag.
…nfig Signed-off-by: DianaMariaDDM <[email protected]>
…ving_prelim_install_authconfig Removing prelim for installing authconfig, as it is not used.
Signed-off-by: Diana-Maria Dumitru <[email protected]>
Signed-off-by: Diana-Maria Dumitru <[email protected]>
…of github.com:siemens/AMAZON2023-CIS into siemens/feat/fixing_tags_for_prelim_capture_etc_psswd
Signed-off-by: Mark Bolwell <[email protected]>
* updated to use ansible_facts variables Signed-off-by: Mark Bolwell <[email protected]> * Squashed commit of the following: commit 0cad737fe35db33ff0b867ac4439688cd2bcb009 Author: Mark Bolwell <[email protected]> Date: Fri Feb 23 09:41:39 2024 +0000 updated and tidied up Signed-off-by: Mark Bolwell <[email protected]> commit 1fa72013209866be66f7f2a353b9cf6264a3681d Author: Mark Bolwell <[email protected]> Date: Fri Feb 23 09:41:10 2024 +0000 audit_only Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Mark Bolwell <[email protected]> * Always tag for 1.2.1 gpg_key package update #14 Signed-off-by: Mark Bolwell <[email protected]> * tidy up prelim removal step Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> * removed inject facts as vars Signed-off-by: Mark Bolwell <[email protected]> * 4.6.5 related to #27 thanks to @DianaMariaDDM Signed-off-by: Mark Bolwell <[email protected]> * 6.1.10 thanks to @DianaMariaDDM #37 Signed-off-by: Mark Bolwell <[email protected]> * tage change to alwasy thanks to @DianaMariaDDM #41 Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]>
* Fixing issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/3 by editing the destination path! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/4 by masking both the socket and the service! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/6 by editing the value of `clientalivecountmax` to 3! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/2 by using `import_tasks` module so as the rules will get added and executed! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/5 by adding the necessary lines to both sshd_config file and sshd_config.d/ files. The same method is used for all the rules from 4.2.x, to make them compliant with CISs checks. Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing trailing whitespaces Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing trailing whitespaces and fixing an end-of-file Signed-off-by: Diana-Maria Dumitru <[email protected]> * Refactoring docs Signed-off-by: Diana-Maria Dumitru <[email protected]> * Small fixings for https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/19 Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing trailing whitespace Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing fail message so that is states the correct number of the rule that requires the root password to be set Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing inconsistencies for issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/22 Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing minor syntax issues by adding missing "PATCH" keywords or missing "|". Signed-off-by: Diana-Maria Dumitru <[email protected]> * Fixing PRELIM task "PRELIM | 4.3.3 | Find all sudoers files" mentioned in issue https://code.siemens.com/infosec-pss-gov/security-crafter-baseline-automations/ansible-lockdown/amazon2023-cis/-/issues/22. Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing 1.1.2.1 from multiline task 1.1.2.2 ,1.1.2.3, 1.1.2.4 because it was not supposed to be there! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing prelim for installing authconfig, as it is not used. Signed-off-by: Diana-Maria Dumitru <[email protected]> * [pre-commit.ci] pre-commit autoupdate updates: - [github.com/pre-commit/pre-commit-hooks: v4.4.0 → v4.5.0](pre-commit/pre-commit-hooks@v4.4.0...v4.5.0) - [github.com/gitleaks/gitleaks: v8.17.0 → v8.18.2](gitleaks/gitleaks@v8.17.0...v8.18.2) - [github.com/ansible-community/ansible-lint: v6.18.0 → v24.2.0](ansible/ansible-lint@v6.18.0...v24.2.0) - [github.com/adrienverge/yamllint.git: v1.32.0 → v1.35.1](https://github.com/adrienverge/yamllint.git/compare/v1.32.0...v1.35.1) * Removing the 6.1.12 duplicate task and adding it to the 6.1.10 task as it was implementing something needed by 6.1.10. Signed-off-by: Diana-Maria Dumitru <[email protected]> * De-commenting allow and deny variables for sshd. Signed-off-by: Diana-Maria Dumitru <[email protected]> * Removing double import of cis_5.3.yml. Signed-off-by: Diana-Maria Dumitru <[email protected]> * As authconfig is not needed anymore, the variable related to its installation is removed! Signed-off-by: Diana-Maria Dumitru <[email protected]> * Feb 24 updates to devel (#58) * updated to use ansible_facts variables Signed-off-by: Mark Bolwell <[email protected]> * Squashed commit of the following: commit 0cad737fe35db33ff0b867ac4439688cd2bcb009 Author: Mark Bolwell <[email protected]> Date: Fri Feb 23 09:41:39 2024 +0000 updated and tidied up Signed-off-by: Mark Bolwell <[email protected]> commit 1fa72013209866be66f7f2a353b9cf6264a3681d Author: Mark Bolwell <[email protected]> Date: Fri Feb 23 09:41:10 2024 +0000 audit_only Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Mark Bolwell <[email protected]> * Always tag for 1.2.1 gpg_key package update #14 Signed-off-by: Mark Bolwell <[email protected]> * tidy up prelim removal step Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> * removed inject facts as vars Signed-off-by: Mark Bolwell <[email protected]> * 4.6.5 related to #27 thanks to @DianaMariaDDM Signed-off-by: Mark Bolwell <[email protected]> * 6.1.10 thanks to @DianaMariaDDM #37 Signed-off-by: Mark Bolwell <[email protected]> * tage change to alwasy thanks to @DianaMariaDDM #41 Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> * updated changelog Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> * updated ansible fact naming and checkout action (#64) * updated ansible fact naming for ansible_facts.virtualization_type Signed-off-by: Mark Bolwell <[email protected]> * updated checkout version Signed-off-by: Mark Bolwell <[email protected]> * ansible fact update Signed-off-by: Mark Bolwell <[email protected]> * updated ansible facts and timeout now inherited Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> * [pre-commit.ci] pre-commit autoupdate (#65) updates: - [github.com/ansible-community/ansible-lint: v24.2.0 → v24.2.1](ansible/ansible-lint@v24.2.0...v24.2.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * 4.2.16: Add variable for SSH MaxAuthTries (#66) Signed-off-by: Tom Henderson <[email protected]> * 4.2.16: Correct variable name and required max value (#67) Signed-off-by: Tom Henderson <[email protected]> * March 24 updates (#68) * addressed #59 thanks to @DianaMariaDDM Signed-off-by: Mark Bolwell <[email protected]> * issue #59 thanks to @DianaMariaDDM Signed-off-by: Mark Bolwell <[email protected]> * issue #62 thanks to @DianaMariaDDM Signed-off-by: Mark Bolwell <[email protected]> * updated variable name in conditional Signed-off-by: Mark Bolwell <[email protected]> * updated Signed-off-by: Mark Bolwell <[email protected]> * updated container check Signed-off-by: Mark Bolwell <[email protected]> * updated authselect PR Signed-off-by: Mark Bolwell <[email protected]> * fix conditional typo Signed-off-by: Mark Bolwell <[email protected]> * fix conditional typo Signed-off-by: Mark Bolwell <[email protected]> * fix var typo Signed-off-by: Mark Bolwell <[email protected]> --------- Signed-off-by: Mark Bolwell <[email protected]> * [pre-commit.ci] pre-commit autoupdate (#69) updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> --------- Signed-off-by: Diana-Maria Dumitru <[email protected]> Signed-off-by: DianaMariaDDM <[email protected]> Signed-off-by: Mark Bolwell <[email protected]> Signed-off-by: Tom Henderson <[email protected]> Co-authored-by: Diana-Maria Dumitru <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: DianaMariaDDM <[email protected]> Co-authored-by: Tom Henderson <[email protected]> Co-authored-by: Tom Henderson <[email protected]>
Overall Review of Changes:
This PR fixes this issue
Issue Fixes:
Enhancements:
None
How has this been tested?:
Not tested.