Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #584/0dbedf57 backport][stable-2] Document MySQL and MariaDB don't store roles with same manner #585

Conversation

patchback[bot]
Copy link

@patchback patchback bot commented Oct 26, 2023

This is a backport of PR #584 as merged into main (0dbedf5).

SUMMARY

To prevent confusion like in #579, I propose to add this code comment.

ISSUE TYPE
  • Docs Pull Request
COMPONENT NAME

module_util: user

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (89d1637) 76.48% compared to head (10de776) 76.14%.
Report is 2 commits behind head on stable-2.

Additional details and impacted files
@@             Coverage Diff              @@
##           stable-2     #585      +/-   ##
============================================
- Coverage     76.48%   76.14%   -0.35%     
============================================
  Files            28       27       -1     
  Lines          2326     2322       -4     
  Branches        545      562      +17     
============================================
- Hits           1779     1768      -11     
- Misses          382      384       +2     
- Partials        165      170       +5     
Flag Coverage Δ
integration 73.06% <ø> (ø)
sanity ?
units 34.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
plugins/module_utils/user.py 84.73% <ø> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@laurent-indermuehle laurent-indermuehle force-pushed the patchback/backports/stable-2/0dbedf57cb988c3a5c3444f79d2da996e101edf1/pr-584 branch from 45aa359 to 10de776 Compare October 27, 2023 11:29
@laurent-indermuehle
Copy link
Collaborator

I pushed a new commit to make GitHub Action realized that the target branch has been updated. It launched 2 sets of tests, one for the push, the other for the merge request.
The first is unaware of the change in the target branch, the second is.
I have no hope to understand how GitHub Actions works -_-'

This is only a comment, I will merge and forget about it ;)

@laurent-indermuehle laurent-indermuehle merged commit 534a6fa into stable-2 Oct 27, 2023
61 of 69 checks passed
@laurent-indermuehle laurent-indermuehle deleted the patchback/backports/stable-2/0dbedf57cb988c3a5c3444f79d2da996e101edf1/pr-584 branch October 27, 2023 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant