Document MySQL and MariaDB don't store roles with same manner #584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #584 +/- ##
==========================================
- Coverage 76.66% 74.77% -1.90%
==========================================
Files 28 18 -10
Lines 2447 2319 -128
Branches 603 583 -20
==========================================
- Hits 1876 1734 -142
- Misses 388 405 +17
+ Partials 183 180 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Andersson007
approved these changes
Oct 26, 2023
|
when you merge, please try to backport it to |
|
Thanks @Andersson007 for the follow up and suggesting to add this comment to the code. I'll try for stable-2. |
laurent-indermuehle
merged commit 0dbedf5
into
ansible-collections:main
39 of 40 checks passed
Backport to stable-2: 💚 backport PR created✅ Backport PR branch: Backported as #585 🤖 @patchback |
patchback bot
pushed a commit
that referenced
this pull request
Oct 26, 2023
(cherry picked from commit 0dbedf5)
laurent-indermuehle
added a commit
that referenced
this pull request
Oct 27, 2023
(cherry picked from commit 0dbedf5)
laurent-indermuehle
added a commit
that referenced
this pull request
Oct 27, 2023
…585) (cherry picked from commit 0dbedf5) Co-authored-by: Laurent Indermühle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
To prevent confusion like in #579, I propose to add this code comment.
ISSUE TYPE
COMPONENT NAME
module_util: user